Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the textSearch API #36

Merged
merged 1 commit into from
May 3, 2024
Merged

Added support for the textSearch API #36

merged 1 commit into from
May 3, 2024

Conversation

cgalvan
Copy link
Collaborator

@cgalvan cgalvan commented May 2, 2024

Description

Added support for the textSearch API.

  • Currently supports query, location, bounds, language, and region request parameters
  • Added unit tests that give full coverage to the new logic added
  • Updated the autoComplete example to make use of the new textSearch API for predictions that are query strings instead of concrete places, so we trigger a textSearch instead of getDetails and can display markers for all the results
  • Added TODO for fast-follow task to extend support for our migration LatLngBounds class

Here is a gif of the autoComplete example showcasing choosing a specific place (which does a getDetails) vs. choosing a query string (which uses the new textSearch)
autocomplete_textsearch

Testing

Built/ran unit tests and verified they all pass. Ran autoComplete example and verified it now does a textSearch request for query string predictions.

@cgalvan cgalvan requested a review from a team as a code owner May 2, 2024 21:37
Copy link
Contributor

@jonayuan jonayuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the GIF!

@cgalvan cgalvan merged commit 955c0f4 into aws-geospatial:main May 3, 2024
1 check passed
@cgalvan cgalvan deleted the AddedTextSearchSupport branch May 3, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants